Prettier! #473
Merged
Prettier! #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `parser` option exists to force prettier to conform to a particular style. The docs recommend that this only be implemented in an `overrides` section, to prevent parsing one file as another. See https://prettier.io/docs/en/configuration.html#setting-the-parserdocsenoptionshtmlparser-option Since the code is linted correctly without the override, and we want to lint Markdown, remove this configuration. Signed-off-by: Mike Fiedler <[email protected]>
Updates commands to catch when Markdown is malformed. Refs: serverless#471 (review) Signed-off-by: Mike Fiedler <[email protected]>
Signed-off-by: Mike Fiedler <[email protected]>
Signed-off-by: Mike Fiedler <[email protected]>
Signed-off-by: Mike Fiedler <[email protected]>
bsamuel-ui
approved these changes
Feb 22, 2020
|
I'm not sure I agree with the single-quote markdown style, so this is an opportunity to decide You did the work, you get to make the call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier is now scoped to all *.js and *.md files - and is used in
lint,ci:lintand behaves the same for the end user if they runnpm run format.I'm not sure I agree with the single-quote markdown style, so this is an opportunity to decide otherwise and place the single-quote configuration directive as part of a
*.jsoverride - I'm open to either.